Billing: contract appear double in billing loops

[DylanVerstraete]

I have identified multiple contracts which appear to be inserted on a index in the billing loop. See

tfchain/substrate-node/pallets/pallet-smart-contract/src/lib.rs

Line 1020 in 2eb3860

Self::insert_contract_in_billing_loop(contract.contract_id);

where contracts are inserted in a billing loop if there are resources pushed or it is created with a public IP or it is any other contract

tfchain/substrate-node/pallets/pallet-smart-contract/src/lib.rs

Line 878 in 2eb3860

Self::insert_contract_in_billing_loop(id);

We need to redesign this because this will cause issues in the long run.

[DylanVerstraete]

Code was added here: 8eaa3de#diff-9621ac9aed0d3dce47f6c26910446b2d480d84bca8a6eb7b7402a2001be9eac7 and deployed on devnet a while ago. So it seems like we didn't think it through enough

[DylanVerstraete]

Let's revert these changes and also add an extra check in the offchain worker:

fetch the contract ->

• check if used resources
• check if used ip
• check if any consumption reports were pushed

IF no => don't make an extrinsic and such will be excluded from billing

[renauter]

New billing loop rules:

1. Each contract (node/rent/name contracts) is inserted in billing loop only once, when contract is created.
   There is no more exception for node contracts with no public ips and no used resources on chain.

2. When a contract is to be billed during the billing loop execution (via the offchain worker), bill it ONLY if there is effectively some IP/SU/CU/NU consumed. Technically this comes down to trigger bill_contract() extrinsic only when there is some used ip / resources or consumption reports linked to this contract.

[DylanVerstraete]

Fix was deployed on devnet, need to verify before we close but its looking good so far.

[DylanVerstraete]

Fix verified