Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go client: Add json tags for objects (twin, farm, node, contract, etc) #677

Closed
brandonpille opened this issue Apr 14, 2023 · 0 comments · Fixed by #678
Closed

Go client: Add json tags for objects (twin, farm, node, contract, etc) #677

brandonpille opened this issue Apr 14, 2023 · 0 comments · Fixed by #678
Assignees
@brandonpille
Labels
type_feature New feature or request

Comments

@brandonpille
Copy link
Contributor

The structs twin, farm, node, etc don't have json tags resulting in the attributes starting with uppercases which is not compliant with json encoding standards. We should add json tags.
@brandonpille brandonpille added the type_feature New feature or request label Apr 14, 2023
@brandonpille brandonpille added this to the 2.4.0 milestone Apr 14, 2023
@brandonpille brandonpille self-assigned this Apr 14, 2023
@brandonpille brandonpille mentioned this issue Apr 14, 2023
Merged
@brandonpille brandonpille linked a pull request Apr 14, 2023 that will close this issue
chore(client:go): added json tags #678
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonpille brandonpille

Labels
type_feature New feature or request
Projects
No open projects
3.10.x
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(client:go): added json tags threefoldtech/tfchain
1 participant
@brandonpille