Some bill contract extrinsics are failing with error

[DylanVerstraete]

ContractWrongBillingLoopIndex

On devnet I checked that contract 21023 was failing with this error, this contract was billed at block 5146505 which resolves to index 305

When checking the index 305 in chainstate I see:

[
  17,744
  20,924
  19,918
]

But when checking index 304 I found the contract:

[
  ...
  21,023
]

So it seems the extrinsic is failing because it tries to lookup the wrong index to remove the contract in

[DylanVerstraete]

I think it's because the offchain worker creates the extrinsics to be included in the next block.

This means that the index that the offchain worker got is different from the index in the next block (index + 1).

We can fix this by subtracting the index with 1 in case contracts need to be deleted.

[renauter]

As you explained, when we first get index here it is in ocw context (at block X)

tfchain/substrate-node/pallets/pallet-smart-contract/src/lib.rs

Line 652 in e3868e9

let current_index = Self::get_current_billing_loop_index();

and then when we effectively remove contract in billing loop we get index here at next block context (X+1)

tfchain/substrate-node/pallets/pallet-smart-contract/src/lib.rs

Line 1617 in e3868e9

let index = Self::get_current_billing_loop_index();

which gives index inconsistency
so indeed, passing billing index to bill_contract() guaranty us to avoid this

no impact when we call bill_contract() out of ocw context (cancel contract / delete node)
because removing contract from billing loop is always triggered by a call to bill_contract() in ocw context

[DylanVerstraete]

Non blocking issue, will be released in 2.4.0

[DylanVerstraete]

Fix deployed and verified on devnet