Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parameter suggestions for classes #245

Closed
RaptorX opened this issue Dec 28, 2022 · 2 comments
Closed

Incorrect parameter suggestions for classes #245

RaptorX opened this issue Dec 28, 2022 · 2 comments

Comments

@RaptorX
Copy link
Contributor

RaptorX commented Dec 28, 2022

In the new version we are getting the this keyword presented as a parameter in classes which is incorrect in the sense that the first parameter you can change is not the THIS itself but the defined parameters.

image

This class only accepts 2 parameters dbFile and overwrite. While is true that the @this parameter exists, it shouldn't be suggested as the first parameter to fill out because you get this:

image

I already set the dbFile parameter but intellisense is telling me that i set the this parameter instead which is incorrect.

Possible solution

I like that the this parameter is shown, but it shouldnt be preselected as the first parameter. Is there a way to set the "second" parameter as highlighted when the intellisense tip is shown?

If that's possible then I would rather have that. If not, maybe having the this keyword as the last parameter or in the worse case, completely removed again :(

@thqby
Copy link
Owner

thqby commented Dec 28, 2022

This bug has been fixed, but I seem to forget to release it.

Currently, @this will not be displayed when calling as a method obj.method(), but will be displayed when calling as a function (obj.method)().

@RaptorX
Copy link
Contributor Author

RaptorX commented Dec 29, 2022

awesome!
Thanks!

@thqby thqby closed this as completed Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants