Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install failure: aarch64 not recognized as equivalent to arm64 #438

Closed
bschofield-va opened this issue Nov 29, 2023 · 1 comment
Closed

Comments

@bschofield-va
Copy link

Describe the bug

Talisman fails to install on some Linux 64 ARM systems, such as Ubuntu Jammy that reports as aarch64 (but it's easily fixed)

$ bash -c "$(curl --silent https://thoughtworks.github.io/talisman/scripts/install.bash)"
Talisman currently only supports x86 and x86_64 and arm64 architectures.
If this is a problem for you, please open an issue: https://github.com/thoughtworks/talisman/issues/new

$ uname -a
Linux fresnel 6.4.16-linuxkit #1 SMP PREEMPT Wed Oct 25 16:32:24 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux

To Reproduce
Steps to reproduce the behavior:

  1. Run the following command from something that is ARM 64, e.g., Mac M1.
docker run -it --rm arm64v8/ubuntu:jammy bash -c 'apt-get update && apt-get install -y curl && bash -c "$(curl --silent https://thoughtworks.github.io/talisman/scripts/install.bash)"'
  1. Feel sad.

Expected behavior
I'd expect Talisman to install since arm64 and aarch64 are equivalent.

In my testing, the architecture case statement can be updated to treat aarch64 as arm64 and Talisman functions as expected.

https://github.com/thoughtworks/talisman/blob/main/global_install_scripts/install.bash#L114

This is how I ultimately installed it:

bash -c "$(curl --silent https://thoughtworks.github.io/talisman/scripts/install.bash | sed 's/"arm64")/"arm64" | "aarch64")/')"

Patch for install.bash

114c114
<     "arm64")
---
>     "arm64" | "aarch64")
@tw-owen-nelson
Copy link
Collaborator

Fixed in #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants