Fix Elixir 1.11 compilation warning #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germsvel
approved these changes
Oct 21, 2020
germsvel
pushed a commit
that referenced
this pull request
Nov 4, 2020
## Motivation I'm getting the following warning after upgrading to elixir 1.11. Related #398 #399. ``` warning: Ecto.Type.cast/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of: 1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs 2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs 3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Type]] to your "def project" in mix.exs lib/ex_machina/ecto_strategy.ex:62: ExMachina.EctoStrategy.cast_value/3 ``` ## Proposed Solution By default, the list of applications to start is automatically inferred from the dependencies. Mix and other tools use the application list in order to start the dependencies before starting the application itself. If we use the `applications:` then no inference is done. In this case `ecto` was not been included as a dependency of the library. A quick solution for this is to use the `extra_applications`, in this way we let the compiler infer from the dependencies list the applications that it needs to start. Links: - https://elixir-lang.org/blog/2017/01/05/elixir-v1-4-0-released/#application-inference - https://hexdocs.pm/mix/Mix.Tasks.Compile.App.html - https://stackoverflow.com/questions/44727642/elixir-mix-file-applications-vs-extra-applications-when-to-use-which
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the compilation warning produced by Ex Machina under Elixir 1.11.
Closes #398