Remove obsolete fields_for/2 function
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Would this fix these types of dialyzer issues? ________________________________________________________________________________
test/support/factory.ex:11:no_return
Function subject_factory/0 has no local return.
________________________________________________________________________________
test/support/factory.ex:3:no_return
Function fields_for/1 has no local return.
________________________________________________________________________________
test/support/factory.ex:8:no_return
Function patient_factory/0 has no local return.
________________________________________________________________________________ |
|
@tielur: Possibly. Try pulling this branch into your mix.exs |
|
I think this makes sense to remove, especially since the deprecation was introduced in 1.0.0 and we're at 2+. Thanks @moxley for providing some info in the PR description! |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
Since version 1.0.0, when users of ex_machina try to call the deprecated
fields_for/2function, it raises an exception. This doesn't seem to provide any benefit. If instead it's removed, calls to it will fail at compile time. But if it stays in, calls will fail at runtime, possibly in production.This PR solves the Dialyzer issue and it provides a better solution for dealing with the obsolete function.