README: Add example of dependent factory #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcsmith
reviewed
Aug 21, 2017
README.md
Outdated
| @@ -104,6 +104,14 @@ defmodule MyApp.Factory do | |||
| } | |||
| end | |||
|
|
|||
| # dependent factory | |||
There was a problem hiding this comment.
I think # Modify existing factories might be more clear here. What do you think?
There was a problem hiding this comment.
Maybe derived factories? That's something I searched for first.
README.md
Outdated
| %MyApp.Article{ | ||
| article_factory | | ||
| featured: true, | ||
| } |
There was a problem hiding this comment.
I think this syntax is a bit nicer. What do you think? struct!(article_factory, %{featured: true})
|
Rebased on master. |
nathanl
changed the title
|
Thanks @nathanl! This is definitely a point of confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may seem obvious, but it took me a few minutes to figure out and I thought it would be nice to show.