Only drop autogenerated ids and not domain ids #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| custom_id: 1, | ||
| name: "Testing" | ||
| } | ||
| end |
There was a problem hiding this comment.
Could you add a newline underneath this?
|
This looks awesome! Just a couple small comments and then I'll merge this in |
explained by test
|
@paulcsmith Fixed the feedback issues. |
|
@geofflane Thank you! |
|
The above doesn't solve the case where I have an auto-incrementing ID which I have chosen to override. For example if I'm using params_for to generate the parameters that I'm using to update a given record. Shall I open an issue for this? |
|
@mootpointer Yes, could you please open an issue with an example of the schema, the factory and the test? I'm not totally sure what you're trying to do so I think that will help us figure it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143. Drops only auto-generated ids and not custom IDs that are meaningful in the domain.