Add insert, insert_pair and insert_list to ExMachina.Ecto, and ExMachina.Strategy #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra information was there for people upgrading from ExMachina 0.4.0. Now that we're getting ready for 1.0 this can be removed.
| @@ -5,7 +5,7 @@ defmodule ExMachina do | |||
| In depth examples are in the [README](README.html) | |||
| """ | |||
|
|
|||
| defmodule UndefinedFactory do | |||
| defmodule UndefinedFactoryError do | |||
There was a problem hiding this comment.
It is Elixir convention to add Error to all errors
paulcsmith
force-pushed
the
ps-89-ecto-insert
branch
from
ddc8837 to
a61e062
Compare
|
|
||
| # Add `except: [build: 2] to the `Ecto.Model` import | ||
| import Ecto.Model, except: [build: 2] | ||
| ``` |
There was a problem hiding this comment.
Ecto changed the function to Ecto.build_assoc so this no longer applies
|
I'll fix the error on Circle sometime this week. @jsteiner any other comments? |
| ```elixir | ||
| defmodule MyApp.Factory do | ||
| use ExMachina.Ecto, repo: MyApp.Repo | ||
| defmodule MyApp.JsonFactory do |
There was a problem hiding this comment.
Can we just call this MyApp.Factory? I think the JsonFactory calls itself out a little too much. Took me a couple seconds to realize it wasn't actually doing any magic and it's irrelevant.
|
Nice! I had a few small comments, but otherwise I think this is a really elegant solution. Great work @paulcsmith! |
|
Thanks for the review @jsteiner! I'm glad you like the new direction. I'll resolve the comments and get this in on Friday :) |
paulcsmith
force-pushed
the
ps-89-ecto-insert
branch
from
d8c8d6f to
fb4c696
Compare
These tests are no longer necessary since this is part of Ecto and is tested there.
paulcsmith
force-pushed
the
ps-89-ecto-insert
branch
from
fb4c696 to
86a8c92
Compare
This was referenced Mar 18, 2016
paulcsmith
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is totally overhauled from what we were originally going to do. Instead base ExMachina will only add
buildfunctions. You can useExMachina.Strategyto define more functions. ExMachina.Ecto uses this under the hood to addinsertfunctions to factories.This PR also removes a bunch of old stuff we're no longer using
Closes #89