Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bourbon’s modular-scale function is still used #337

Closed
tysongach opened this issue Oct 19, 2019 · 0 comments · Fixed by #356
Closed

Bourbon’s modular-scale function is still used #337

tysongach opened this issue Oct 19, 2019 · 0 comments · Fixed by #356
Assignees
@keiranking
Labels
bug
Milestone
v2.0.3

Comments

@tysongach
Copy link
Contributor

Bourbon was removed in e2303a1, but it's modular-scale function is still used for setting font-size on heading elements:

bitters/core/_typography.scss

Line 15 in 3ded620

font-size: modular-scale(1);

This means the CSS output is invalid.
@tysongach tysongach added the bug label Oct 19, 2019
@tysongach tysongach changed the title Bourbon Bourbon’s modular-scale function is still used Oct 19, 2019
@vendelal vendelal added this to the v2.0.3 milestone Oct 24, 2019
@keiranking keiranking self-assigned this Oct 25, 2019
@keiranking keiranking mentioned this issue Oct 25, 2019
Merged
@tysongach tysongach mentioned this issue Oct 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keiranking keiranking

Labels
bug
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging a pull request may close this issue.

Remove Bourbon modular-scale function thoughtbot/bitters
3 participants
@tysongach @vendelal @keiranking