Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Deps Discrepancy #3337

Open
maryclair-bh opened this issue Jan 21, 2025 · 0 comments
Open

Query Deps Discrepancy #3337

maryclair-bh opened this issue Jan 21, 2025 · 0 comments

Comments

@maryclair-bh
Copy link

maryclair-bh commented Jan 21, 2025

After we performed a recent Please upgrade, we noticed major differences between the output of please query deps in version 17.8.7 (our previous version) and the latest, 17.12.7. In particular the latest version is only finding a small portion of the targets that the previous version did.

We were using please query deps to have a comprehensive push all docker images alias in our repo that considered dependencies (since docker requires that). However, you can also see the behavior with a simpler use case on the please repo itself: with Please version 17.8.7, the command

please query deps --include=hlink:plz-out/pkg  //...

generates the following output:

//docs:deep-tarball
//docs:tarball
//package:signer
//tools/misc:gen_release
//tools/performance:gen_parse_tree
//tools/performance:parse_perf_test

The same command with Please version 17.12.7 produces no output.

We would be interested to know if the recent changes to query deps in PR 3204 are indeed intended to essentially change the definition of the function, or if the behavior that we are seeing is unexpected? It is possible that we misunderstood the purpose of the functionality in the first place, and if so we would appreciate some clarification on its purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant