Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination doesn't support more than 2 pages #70

Closed
glungley opened this issue Jul 30, 2020 · 1 comment
Closed

Pagination doesn't support more than 2 pages #70

glungley opened this issue Jul 30, 2020 · 1 comment

Comments

@glungley
Copy link

https://github.com/thomaxxl/safrs/blame/master/safrs/jsonapi_formatting.py#L140

MAX_PAGE_LIMIT limits the size of a page (default 250).
This value is also used to limit the size of the page offset.

Therefore only limit + page offset records can be fetched. Meaning only the first MAX_PAGE_LIMIT*2 (500) records can be fetched.
@thomaxxl
Copy link
Owner

Thanks for reporting this issue!
I added a MAX_PAGE_OFFSET config parameter (cb7fba7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomaxxl @glungley