Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Tracing no longer working #2479

Closed
hairyhenderson opened this issue Oct 7, 2024 · 3 comments · Fixed by #2482
Closed

(bug) Tracing no longer working #2479

hairyhenderson opened this issue Oct 7, 2024 · 3 comments · Fixed by #2482
Labels
bug Something isn't working p1 High priority

Comments

@hairyhenderson
Copy link
Contributor

Observed behaviour

Since #1503, the OTel service's Init() method is no longer being called. As a result, tracing is no longer working.

Expected Behavior

Tracing should work!

Steps to reproduce

No response
@hairyhenderson hairyhenderson added bug Something isn't working needs-triage A priority should be added to the issue labels Oct 7, 2024
@hairyhenderson
Copy link
Contributor Author

I've got a local fix in play, PR coming soon...

@thomaspoignant thomaspoignant removed the needs-triage A priority should be added to the issue label Oct 8, 2024
@thomaspoignant thomaspoignant removed their assignment Oct 8, 2024
@thomaspoignant thomaspoignant added the p1 High priority label Oct 8, 2024
@thomaspoignant
Copy link
Owner

Hey @hairyhenderson I am sorry for that, I did not spotted this regression.
If you have a PR ready can you open it and we can work from there.

@hairyhenderson hairyhenderson mentioned this issue Oct 8, 2024
Merged
4 tasks
@hairyhenderson
Copy link
Contributor Author

I've got a fix up here: #2482

@hairyhenderson hairyhenderson mentioned this issue Oct 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working p1 High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tracing): Restore OTel tracing support hairyhenderson/go-feature-flag
2 participants
@hairyhenderson @thomaspoignant