Difference in coding between shinyFilesChoose and shinyFileSave

[WilDoane]

There appears to be a small difference between the implementations of shinyFilesChoose and shinyFileSave where Save causes immediate evaluation of the triple-dots (...) arguments.

Choose defers creating the fileGetter until sendDirectoryData is invoked while Save immediately (and outside a reactive context) creates the fileGetter, thereby causing the evaluation of the triple-dots (...) arguments.

Is there a reason for this? Is it necessary?

Because of this, these two similar functions have different performance behavior in server code: shinyFilesChoose can rely upon reactive expressions in the ... arguments while shinyFileSave cannot.

shinyFiles/R/filechoose.R

Line 222 in da36135

shinyFileChoose <- function(input, id, updateFreq = 0, session = getSession(),

shinyFiles/R/filesave.R

Line 29 in da36135

shinyFileSave <- function(input, id, updateFreq = 0, session = getSession(),