Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update demo #33

Closed
benmccann opened this issue May 29, 2020 · 2 comments · Fixed by #44
Closed

Update demo #33

benmccann opened this issue May 29, 2020 · 2 comments · Fixed by #44

Comments

@benmccann
Copy link
Contributor

The README links to https://github.com/beyonk-adventures/now-sapper-demo. Feedback from a user on Discord:

still uses now instead of vercel command, has .nowignore instead of .vercelignore, the server.js configuration does not build on now, there is no vercel.json in the root folder (still has now.json)

The user also provided their own sample project that could be an alternative if it's not a priority to update the existing demo: https://github.com/articnet/sapper-vercel
@antony
Copy link
Collaborator

antony commented May 31, 2020

@benmccann happy to update the demo / accept a PR to update it.

@thgh
Copy link
Owner

thgh commented May 31, 2020

An examples folder sounds good to me!

@antony antony mentioned this issue Jul 4, 2020
Merged
@thgh thgh closed this as completed in #44 Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/memory config thgh/vercel-sapper
3 participants
@antony @benmccann @thgh