Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change the number of generated scrambles for 3x3 multiple blindfolded when a suggested number is present #896

Open
viroulep opened this issue Jan 8, 2024 · 2 comments

Comments

@viroulep
Copy link
Contributor

viroulep commented Jan 8, 2024

Actual (problem) behavior

When generating scrambles for a competition with multiple blindfolded, I can't change the suggested number of scrambles generated per attempt.

Expected behavior

I can change the number of scrambles generated per attempt.
The number seems based on the personal best of the first person on the psychsheet, but I'd definitely expect to be able to generate a few more as they may attempt to break their best result.

Steps To Reproduce

I think WST members can manage any competition, so looking at http://localhost:2014/scramble?competitionId=PourGesteJaiGateau2024 should just work; otherwise one would have to use a competition with multi and with competitors registered for the event and a personal best.

Desktop

  • OS: Debian bookworm
  • Browser including version: Firefox 121.0, Google Chrome 120.0.6099.199
  • TNoodle Version: 1.2.1
  • Java version:
$ java -version
openjdk version "17.0.8" 2023-07-18
OpenJDK Runtime Environment (build 17.0.8+7-Debian-1deb12u1)
OpenJDK 64-Bit Server VM (build 17.0.8+7-Debian-1deb12u1, mixed mode, sharing)

Additional context

I did not investigate, but it looks like a react state not being updated upon the user input.

Workaround

I generated the multi scrambles on their own manually.

@gregorbg
Copy link
Member

gregorbg commented Jan 8, 2024

Yup, that was a React state conflicting with the WCIF extension.
Fixed on master, just needs to be packed into an actual release

@viroulep
Copy link
Contributor Author

viroulep commented Jan 8, 2024

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants