Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change_target_file_path #2648

Merged
merged 2 commits into from
May 29, 2024
Merged

change_target_file_path #2648

merged 2 commits into from
May 29, 2024

Conversation

h4l0gen
Copy link
Contributor

@h4l0gen h4l0gen commented May 29, 2024

Description of the changes being introduced by the pull request:
changes target path in basic_repo.py

Fixes #2304

Signed-off-by: h4l0gen <ks3913688@gmail.com>
@h4l0gen
Copy link
Contributor Author

h4l0gen commented May 29, 2024

IMO, this should works for us, I've used this pattern, as this uses accurate path

a PATHPATTERN of "targets/*.tgz" would match file paths "targets/foo.tgz" and "targets/bar.tgz", but not "targets/foo.txt".

@coveralls
Copy link

coveralls commented May 29, 2024

Pull Request Test Coverage Report for Build 9282068183

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.573%

Totals Coverage Status
Change from base Build 9264477504: 0.0%
Covered Lines: 1449
Relevant Lines: 1474

💛 - Coveralls

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem to match the target path that gets used, thanks.

This mergeable as is but if you want you can also try making this comment a little more sensible:

#      |----base URL---||-------target path-------|
# e.g. tuf-examples.org/repo_example/basic_repo.py

could be something like this to match the actual targetpath in the code

#      |--- base artifact URL ---||----- target path -----|
# e.g. tuf-examples.org/artifacts/manual_repo/basic_repo.py

Signed-off-by: Kapil Sharma <ks3913688@gmail.com>
@h4l0gen
Copy link
Contributor Author

h4l0gen commented May 29, 2024

SGTM, made changes. PTAL

@jku jku merged commit 2f80ad5 into theupdateframework:develop May 29, 2024
15 checks passed
@jku
Copy link
Member

jku commented May 29, 2024

thanks

@h4l0gen h4l0gen deleted the change_path branch May 30, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delegated path pattern does not match the target path in basic_repo.py
3 participants