-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngclient: avoid lstrip(os.sep) on target paths #1506
Comments
some additional thoughts here, first for pathpattern:
For target_filepath:
|
RFC2119 states:
IMNSHO the reference implementation does not have a valid reason to ignore any RECOMMENDED/SHOULD entry in the specification and doing so does not make us stricter than the spec. |
I am going to address this issue in my pr #1512. |
Description of issue or feature request:
During matching of target file path and pathpattern in ngclient/updater.py we normalize the paths by removing the leading os separator.
Current behavior:
Normalize file path and pathpattern in case they start with
os.sep
Expected behavior:
Define a valid target file path and pathpattern strings and reject everything else.
Don't support corner cases.
The text was updated successfully, but these errors were encountered: