Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngclient: use MetaFile/TargetFile verification API when it exists #1410

Closed
jku opened this issue May 21, 2021 · 0 comments · Fixed by #1467
Closed

ngclient: use MetaFile/TargetFile verification API when it exists #1410

jku opened this issue May 21, 2021 · 0 comments · Fixed by #1467
Assignees
@sechkova
Labels
backlog Issues to address with priority for current development goals ngclient
Milestone
weeks26-27

Comments

@jku
Copy link
Member

jku commented May 21, 2021 •
edited
Loading

Related to #1377 and #1361: Once Metadata API offers the verification functionality, we should use it in ngclient and verify file lengths and hashes for both metadata and targets.

This would mean removal of helper functions like _check_file_length() _check_hashes_obj(), and removal of hash checking code in metadatabundle
@jku jku added the ngclient label May 21, 2021
@jku jku mentioned this issue May 21, 2021
Merged
@sechkova sechkova added the backlog Issues to address with priority for current development goals label Jun 9, 2021
@sechkova sechkova self-assigned this Jun 23, 2021
@sechkova sechkova added this to the weeks26-27 milestone Jun 23, 2021
@sechkova sechkova mentioned this issue Jun 25, 2021
Merged
3 tasks
@jku jku closed this as completed in #1467 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sechkova sechkova

Labels
backlog Issues to address with priority for current development goals ngclient
Projects
None yet
Milestone
weeks26-27
Development

Successfully merging a pull request may close this issue.

ngclient: use MetaFile/TargetFile verification sechkova/tuf
2 participants
@jku @sechkova