Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gorilla-mux #1335

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Conversation

justincormack
Copy link
Contributor

This now uses the standard Go context package rather than
gorilla-context expect on Go 1.6 and earlier. As the context
packages should not be mixed this is better.

Have not removed gorilla-context as vndr still thinks it is
required, nut it will not be used.

Signed-off-by: Justin Cormack justin.cormack@docker.com

This now uses the standard Go context package rather than
gorilla-context expect on Go 1.6 and earlier. As the context
packages should not be mixed this is better.

Have not removed gorilla-context as `vndr` still thinks it is
required, nut it will not be used.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cyli cyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyli cyli merged commit 39e32b3 into notaryproject:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants