client: improve constructor checks and docs #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduce and explicit nil-check on the metadata store in `NewNotaryRepository()`, to match the docstring and to avoid further panics at runtime. It also clarify the default behavior in case of a nil remote store. Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
|
Can one of the admins verify this patch? |
|
jenkins, test this please |
riyazdf
approved these changes
Jul 6, 2017
|
LGTM thanks! |
endophage
approved these changes
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces and explicit nil-check on the metadata store in
NewNotaryRepository(), to match the docstring and to avoid furtherpanics at runtime.
It also clarifies the default behavior in case of a nil remote store and of
a nil roundtripper.
Signed-off-by: Luca Bruno luca.bruno@coreos.com