Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resign TUF metadata without changes (e.g. close to expiry) #239

Closed
asraa opened this issue Mar 21, 2022 · 7 comments
Closed

Resign TUF metadata without changes (e.g. close to expiry) #239

asraa opened this issue Mar 21, 2022 · 7 comments

Comments

@asraa
Copy link
Contributor

asraa commented Mar 21, 2022

@ethan-lowman-dd @mnm678 this came up when using delegations from #175, but also applies to root and targets: how do you deal with re-signing delegations? let's suppose no change is made to a delegation, but expiraiton is coming up and we need to resign and increment the expiration/version. Right now adding the delegation again will return an error that it already exists, and re-signing with Sign does not increment a version, it just updates the signatures.

We basically need a "snapshot/timestamp" but for other meta.

@asraa
Copy link
Contributor Author

asraa commented Mar 21, 2022

We currently don't really have an API for this, my proposal is adding something like SignWithIncrement.

@asraa
Copy link
Contributor Author

asraa commented Mar 23, 2022

Related: theupdateframework/python-tuf#1727

bump_expiry was removed, and expiration is manually bumped.

@asraa
Copy link
Contributor Author

asraa commented Mar 24, 2022

FWIW for delegations and targets adding an existing target will do a version bump with a no-op

@znewman01
Copy link
Contributor

What's the relationship between this issue and #329 ?

@asraa
Copy link
Contributor Author

asraa commented Sep 28, 2022

What's the relationship between this issue and #329 ?

This is to re-sign any metadata, like targets, root, delegations: we want to re-fresh the signature and bump the version.

SImply using the repo.Sign won't increment version.

go-tuf/repo.go

Line 806 in f75cbcc

func (r *Repo) Sign(roleFilename string) error {

@asraa
Copy link
Contributor Author

asraa commented Sep 28, 2022

e.g. targets.json is expiring, but we aren't removing or adding targets, no change: so we need to bump the version and expiration

@rdimitrov
Copy link
Contributor

Closing since the code base changed and is no longer relevant

Thanks for raising this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants