Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

figure out best way to manage plugin dependencies through just this project's package.json #25

Closed
1 of 5 tasks
thescientist13 opened this issue Aug 11, 2021 · 1 comment · Fixed by #2, #46 or #67
Closed
1 of 5 tasks

figure out best way to manage plugin dependencies through just this project's package.json #25

thescientist13 opened this issue Aug 11, 2021 · 1 comment · Fixed by #2, #46 or #67
Assignees
@thescientist13
Labels
0.8.0 chore question Further information is requested
Milestone
MVP

Comments

@thescientist13
Copy link
Owner

thescientist13 commented Aug 11, 2021 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Currently users have to install this set of peerDependencies right now

This is not ideal as users have to then manage on their own, as opposed to just being an "implementation" detail.

Details

Considerations

  1. Make sure Greenwood doesn't choke on non "UI" devDependencies
  2. See if we can also re-export the other @greenwood/plugin-* plugins as part if index.js itself
@thescientist13 thescientist13 added the enhancement New feature or request label Aug 11, 2021
@thescientist13 thescientist13 added this to the MVP milestone Aug 11, 2021
@thescientist13 thescientist13 self-assigned this Aug 11, 2021
@thescientist13 thescientist13 mentioned this issue Aug 11, 2021
Closed
16 tasks
@thescientist13
Copy link
Owner Author

Or at least just drop the plugins? Per #2 I don't see why we need it, at least not and just run this in SPA mode, combined with some of the suggestions here seems like a really combination
#19 (comment)

@thescientist13 thescientist13 mentioned this issue Aug 27, 2021
Merged
@thescientist13 thescientist13 linked a pull request Sep 2, 2021 that will close this issue
drop graphql for fetch #2
Merged
@thescientist13 thescientist13 reopened this Sep 2, 2021
@thescientist13 thescientist13 added the question Further information is requested label Sep 7, 2021
@thescientist13 thescientist13 changed the title figure out best way to manage dependencies through just this project's package.json figure out best way to manage plugin dependencies through just this project's package.json Sep 7, 2021
@thescientist13 thescientist13 added chore and removed enhancement New feature or request labels Sep 7, 2021
@thescientist13 thescientist13 mentioned this issue Sep 7, 2021
Merged
@thescientist13 thescientist13 linked a pull request Sep 7, 2021 that will close this issue
forgot to update lock file #46
Merged
@thescientist13 thescientist13 mentioned this issue Nov 7, 2023
Merged
2 tasks
@thescientist13 thescientist13 linked a pull request Nov 10, 2023 that will close this issue
Enhancement/issue 25 remove lit dependency #67
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
0.8.0 chore question Further information is requested
Projects
None yet
Milestone
MVP
1 participant
@thescientist13