Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links with extra space on the tag text creates an incorrect markdown syntax #119

Closed
andreskrey opened this issue Dec 28, 2016 · 0 comments
Closed

Links with extra space on the tag text creates an incorrect markdown syntax #119

andreskrey opened this issue Dec 28, 2016 · 0 comments

Comments

@andreskrey
Copy link
Contributor

Consider the following HTML

<a href="someurl.com"><h3>Text</h3></a>

This HTML creates the following markdown

[### Text

](someurl.com)

This is happens due to the header converter adds two newlines. This is correct. The problem resides in the link converter that doesn't sanitize the text in any way. Link text should be trimmed in order to avoid this issue.
@andreskrey andreskrey changed the title Links with extra space on the text creates an incorrect markdown syntax Links with extra space on the tag text creates an incorrect markdown syntax Dec 28, 2016
@andreskrey andreskrey mentioned this issue Dec 28, 2016
Merged
@Sylry Sylry mentioned this issue May 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colinodell @andreskrey