Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for null values to be passed to Scope #553

Merged
merged 4 commits into from
Apr 11, 2022
Merged

allow for null values to be passed to Scope #553

merged 4 commits into from
Apr 11, 2022

Conversation

matthewtrask
Copy link
Contributor

@matthewtrask matthewtrask commented Apr 11, 2022 •
edited
Loading

fixes #551

@matthewtrask matthewtrask requested review from Nyholm and removed request for Nyholm April 11, 2022 11:56
@Nyholm
Copy link
Member

Nyholm commented Apr 11, 2022

Lovely. Thank you. Could we add a small test for this too?

@matthewtrask
Copy link
Contributor Author

@Nyholm Im working on the test now.

@matthewtrask
Copy link
Contributor Author

@Nyholm test cases added

Nyholm
Nyholm approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@matthewtrask matthewtrask merged commit 94ce1fd into master Apr 11, 2022
@freekmurze
Copy link

This change seems to be breaking for all users of spatie/fractalistic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON structure changed between v0.19.2 and v0.20.0
3 participants
@matthewtrask @Nyholm @freekmurze