Add DoctrinePaginatorAdapter to interface with Doctrine pagination #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greydnls
reviewed
Feb 22, 2017
| * @param callable $routeGenerator | ||
| * | ||
| */ | ||
| public function __construct(Paginator $paginator, $routeGenerator) |
greydnls
reviewed
Feb 22, 2017
| * | ||
| * @return callable | ||
| */ | ||
| public function getRouteGenerator() |
There was a problem hiding this comment.
Is there a need to get this outside of this class?
greydnls
requested changes
Feb 22, 2017
|
All fair points, agreed. Unfortunately it is required to bring in the 'doctrine/orm' package to allow the tests to run but it is only require-dev. EDIT: Ah looks like you removed the comment regarding the 'doctrine/orm' package. I seen it in email and didn't cross reference to here |
|
Yeah, I commented before realizing it was require-dev. You're all good! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.