From c504a7bdb9b9f07751d5e6d2e94943fda7bea746 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dafydd=20Ll=C5=B7r=20Pearson?= Date: Fri, 3 Jan 2025 11:18:43 +0000 Subject: [PATCH] chore: Remove hardcoded node version --- .github/workflows/pull-request.yml | 18 ++++++------------ .github/workflows/push-main.yml | 6 ++---- .github/workflows/regression-tests.yml | 12 ++++-------- 3 files changed, 12 insertions(+), 24 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 0532010d74..3180d927c9 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -84,8 +84,7 @@ jobs: version: ${{ vars.PNPM_VERSION }} - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - run: pnpm install --frozen-lockfile @@ -128,8 +127,7 @@ jobs: version: ${{ vars.PNPM_VERSION }} - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - name: Install dependencies @@ -165,8 +163,7 @@ jobs: version: ${{ vars.PNPM_VERSION }} - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - name: Setup .gitconfig @@ -198,8 +195,7 @@ jobs: - uses: actions/setup-node@v4 if: steps.cache-react-build-assets.outputs.cache-hit != 'true' with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - name: Setup .gitconfig @@ -256,8 +252,7 @@ jobs: version: ${{ vars.PNPM_VERSION }} - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - run: pnpm install --frozen-lockfile @@ -470,8 +465,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - name: Setup .gitconfig diff --git a/.github/workflows/push-main.yml b/.github/workflows/push-main.yml index 39322ccb74..d99d4d7b71 100644 --- a/.github/workflows/push-main.yml +++ b/.github/workflows/push-main.yml @@ -19,8 +19,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} # https://docs.github.com/en/free-pro-team@latest/actions/guides/caching-dependencies-to-speed-up-workflows#using-the-cache-action - name: NPM cache uses: actions/cache@v4 @@ -77,8 +76,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} - name: Configure AWS Credentials uses: aws-actions/configure-aws-credentials@v4 with: diff --git a/.github/workflows/regression-tests.yml b/.github/workflows/regression-tests.yml index cd8e3a613e..c8602c0b2b 100644 --- a/.github/workflows/regression-tests.yml +++ b/.github/workflows/regression-tests.yml @@ -35,8 +35,7 @@ jobs: version: ${{ vars.PNPM_VERSION }} - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - run: pnpm install --frozen-lockfile @@ -75,8 +74,7 @@ jobs: version: ${{ vars.PNPM_VERSION }} - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - name: Setup .gitconfig @@ -112,8 +110,7 @@ jobs: version: ${{ vars.PNPM_VERSION }} - uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - name: Setup .gitconfig @@ -146,8 +143,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v4 with: - # node-version: ${{ vars.NODE_VERSION }} - node-version: 22.10.0 + node-version: ${{ vars.NODE_VERSION }} cache: "pnpm" cache-dependency-path: "**/pnpm-lock.yaml" - name: Setup .gitconfig