[BUGFIX] Resolves pages flickering & public key cursor on hover #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peer-entries items on page load to prevent flickering as JS hides it
…tatus page flashing on load as well. Peers list page done for cursor pointer too
rcmcdonald91
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tunnel list page featuring the tunnel's public key in a table and the Peers list page featuring the peer's public key both have JS events alowing the user to click on them to copy their value, however I only kno about this due to looking at the source code and console errors (previous PR fixed); Having the cursor set to pointer will at least show the user it's clickable, and hopefully they find out it copies the value. Being able to provide a toast or similar may be more useful for UX feedback.
When loading tunnels page or status page, the DOM will flicker as divs are loaded with a display but JS then hides them when loaded.
This PR:
cursor: pointeris set on the Tunnel list page and the peers lis page for the Tunne / Peer public key field which is truncated