Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark suite & call it in CI #87

Closed
djahandarie opened this issue Mar 8, 2023 · 2 comments
Closed

Add benchmark suite & call it in CI #87

djahandarie opened this issue Mar 8, 2023 · 2 comments
Assignees
Labels
area/performance The issue or PR is related to performance kind/enhancement The issue or PR is a new feature or request kind/meta The issue or PR is meta triage/accepted The issue or PR is ready to be actively worked on

Comments

@djahandarie
Copy link
Collaborator

djahandarie commented Mar 8, 2023

There are a couple of performance-related issues in the tracker, so I think it'd help the maturity of the project if we had a simple benchmark suite of a few of the most important top-level functions (db lookups, scans, popup generation with long amounts of text, etc) to start, so we could track improvements and regressions in our PRs.

Many of the things in test/ could probably be converted into benchmarks, though we'd likely need to adapt each of them to actually be working on a realistically large input for them to be representative of real-world usage.

References:

@djahandarie djahandarie added kind/enhancement The issue or PR is a new feature or request kind/meta The issue or PR is meta triage/accepted The issue or PR is ready to be actively worked on area/performance The issue or PR is related to performance labels Mar 8, 2023
@siikamiika
Copy link
Collaborator

I can try to do this

@Casheeew
Copy link
Collaborator

Casheeew commented Jan 1, 2024

vitest supports bench functions: https://vitest.dev/api/#bench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance The issue or PR is related to performance kind/enhancement The issue or PR is a new feature or request kind/meta The issue or PR is meta triage/accepted The issue or PR is ready to be actively worked on
Projects
None yet
Development

No branches or pull requests

3 participants