Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Typography Control without font-family default value #951

Closed
abouolia opened this issue Apr 30, 2016 · 2 comments
Closed

Reset Typography Control without font-family default value #951

abouolia opened this issue Apr 30, 2016 · 2 comments
Labels

Comments

@abouolia
Copy link
Contributor

Issue description:

Reset button doesn't work with typography control when it has not font family default value.

Here's my config code

Kirki::add_field('my_theme', array(
        'type'        => 'typography',
        'settings'    => 'my_theme_entry_title',
        'label'       => __('Entry Title', 'my_theme'),
        'description' => __('' ),
        'section'     => 'posts',
        'priority'    => 40,
        'default'     => array(
            'font-size'      => '26px',
            'line-height'    => $body__line_height,
        ),
        'output'      => array(
            array(
                 'element' => '.entry-title'
            ),
        ),
    ) );
@vladcosorg
Copy link
Contributor

Can confirm, reset on typography field is buggy in this case.

@aristath
Copy link
Contributor

Good catch!

It never occurred to me that some people may use the typography control without a font-family...
Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants