Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button/carousel): added DeepPartial Typing #649

Merged
merged 1 commit into from
Mar 4, 2023
Merged

fix(button/carousel): added DeepPartial Typing #649

merged 1 commit into from
Mar 4, 2023

Conversation

Ncookiez
Copy link
Contributor

@Ncookiez Ncookiez commented Mar 4, 2023

fix #646

Description

This PR just adds the DeepPartial type to optional custom themes for two components (Button & Carousel) that were missing that. For both, deep merging with the base theme was already setup.

Fixes #646

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Breaking changes

None.

How Has This Been Tested?

Just the regular tests with yarn test, and linting tests with prettier and eslint.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (ed74d13) 99.42% compared to head (ee5abef) 99.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         130      130           
  Lines        6411     6413    +2     
  Branches      477      477           
=======================================
+ Hits         6374     6376    +2     
  Misses         37       37           
Impacted Files Coverage Δ
src/lib/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/lib/components/Carousel/Carousel.tsx 98.97% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you

@tulup-conner tulup-conner added this to the 1.0.0 milestone Mar 4, 2023
@tulup-conner tulup-conner merged commit 863a789 into themesberg:main Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some components' theme={} don't allow partials
2 participants