Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/components/buttons): Add target to Button props to open a link in new tab #631

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

fsioni
Copy link
Contributor

@fsioni fsioni commented Feb 28, 2023

Description

Added the attribute target to the ButtonProps interface. This enables to add target="_blank" to a button to open the associated link in a new browser tab
This closes #644

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

…o open a link in a new tab

Added the attribute target to the ButtonProps interface. This enables to add target="_blank" to a
button to open the associated link in a new browser tab
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (6b67c6c) 99.42% compared to head (b3cb8b0) 99.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #631   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         130      130           
  Lines        6410     6411    +1     
  Branches      477      477           
=======================================
+ Hits         6373     6374    +1     
  Misses         37       37           
Impacted Files Coverage Δ
src/lib/components/Button/Button.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fsioni fsioni changed the title Add target to button props to open a link in new tab (fix)lib/components/buttons Add target to button props to open a link in new tab Mar 1, 2023
@fsioni fsioni changed the title (fix)lib/components/buttons Add target to button props to open a link in new tab fix(lib/components/buttons): Add target to button props to open a link in new tab Mar 1, 2023
@fsioni fsioni changed the title fix(lib/components/buttons): Add target to button props to open a link in new tab fix(lib/components/buttons): Add target to Button props to open a link in new tab Mar 3, 2023
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rluders rluders merged commit ed74d13 into themesberg:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button doesn't take a target="" props
2 participants