Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RangeSlider): range slider with custom theme, storybook, unit test and docs #548

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

yoku2010
Copy link
Contributor

@yoku2010 yoku2010 commented Jan 19, 2023

Description

Implemented the RangeSlider component as described in the core library.

This component has:

  • Theme support
  • Storybook
  • Unit test
  • Documentation

Fixes #188

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

  • Create a RangeSlider with sizing and theme optional props.
  • Allowed all the HTML attributes of <input type="range" />
  • RangeSlider component in storybook
  • Documentation in the Forms section (see the below screenshot)

Screenshot 2023-01-19 at 1 37 29 PM

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 99.28% // Head: 99.29% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ee72091) compared to base (a2d3f74).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   99.28%   99.29%           
=======================================
  Files         129      131    +2     
  Lines        5713     5775   +62     
  Branches      478      480    +2     
=======================================
+ Hits         5672     5734   +62     
  Misses         41       41           
Impacted Files Coverage Δ
src/lib/components/RangeSlider/RangeSlider.tsx 100.00% <100.00%> (ø)
src/lib/components/RangeSlider/index.ts 100.00% <100.00%> (ø)
src/lib/components/index.ts 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rluders rluders merged commit 5f01946 into themesberg:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: Range slider
2 participants