Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce: [#436] add RightIcon #437

Merged
merged 5 commits into from
Dec 22, 2022

Conversation

DaRabus
Copy link
Contributor

@DaRabus DaRabus commented Nov 21, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

DEMO

image

@DaRabus DaRabus changed the title fix: [#436] add RightIcon introduce: [#436] add RightIcon Nov 21, 2022
src/lib/components/FormControls/TextInput/TextInput.tsx Outdated Show resolved Hide resolved
src/lib/theme/default.ts Outdated Show resolved Hide resolved
src/lib/components/Flowbite/FlowbiteTheme.ts Outdated Show resolved Hide resolved
@DaRabus DaRabus marked this pull request as ready for review November 22, 2022 07:58
@rluders
Copy link
Collaborator

rluders commented Nov 27, 2022

@DaRabus could you please check the code style? CI isn't happy with something. :)

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 97.41% // Head: 97.38% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (913c799) compared to base (4934a89).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 913c799 differs from pull request most recent head 24cc1fc. Consider uploading reports for the commit 24cc1fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   97.41%   97.38%   -0.04%     
==========================================
  Files         127      127              
  Lines        5460     5386      -74     
  Branches      443      444       +1     
==========================================
- Hits         5319     5245      -74     
  Misses        141      141              
Impacted Files Coverage Δ
src/lib/components/TextInput/TextInput.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)
src/lib/components/Radio/Radio.tsx 100.00% <0.00%> (ø)
src/lib/components/Navbar/Navbar.tsx 100.00% <0.00%> (ø)
src/lib/components/Checkbox/Checkbox.tsx 100.00% <0.00%> (ø)
src/lib/components/Navbar/NavbarLink.tsx 100.00% <0.00%> (ø)
src/lib/components/Navbar/NavbarBrand.tsx 100.00% <0.00%> (ø)
src/lib/components/FileInput/FileInput.tsx 100.00% <0.00%> (ø)
src/lib/components/Navbar/NavbarToggle.tsx 100.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DaRabus DaRabus force-pushed the introduce/add-right-icon-textfield branch from 654a7d9 to 913c799 Compare December 12, 2022 10:03
@DaRabus
Copy link
Contributor Author

DaRabus commented Dec 12, 2022

@rluders Added a Integration test and updated the Fork 🗡️

should be able to merge it before years end :)

@rluders rluders merged commit 7d72e1e into themesberg:main Dec 22, 2022
@rluders
Copy link
Collaborator

rluders commented Dec 22, 2022

Thank you, @DaRabus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants