Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Allow Label as self-closing tag, resolves #173 #207

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

tulup-conner
Copy link
Collaborator

@tulup-conner tulup-conner commented Jun 6, 2022

Breaking changes

You can now declare a <Label /> as a self-closing tag. Instead of children, provide value:

<Label htmlFor="email" value="Your email" />

Features

Tests

Unit

@tulup-conner tulup-conner changed the title feat(component): Allow Label as self-closing tag feat(component): Allow Label as self-closing tag, resolves #173 Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #207 (5fa6f4a) into main (9cd1eab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         127      127           
  Lines        7277     7287   +10     
  Branches      826      830    +4     
=======================================
+ Hits         7199     7209   +10     
  Misses         78       78           
Impacted Files Coverage Δ
src/lib/components/FormControls/Label.spec.tsx 100.00% <100.00%> (ø)
src/lib/components/FormControls/Label.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd1eab...5fa6f4a. Read the comment docs.

@tulup-conner tulup-conner marked this pull request as ready for review June 6, 2022 22:38
@tulup-conner tulup-conner requested a review from rluders June 6, 2022 22:38
@tulup-conner tulup-conner self-assigned this Jun 7, 2022
@rluders rluders linked an issue Jun 8, 2022 that may be closed by this pull request
@rluders rluders merged commit 17f5e8e into themesberg:main Jun 8, 2022
@tulup-conner tulup-conner deleted the feat/self-closing-label branch June 8, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Label to use value & children
2 participants