Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): theme support to modal #197

Merged
merged 3 commits into from
Jun 5, 2022

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Jun 5, 2022

Breaking changes

Modal can be customized using

  modal: {
    base: string;
    show: FlowbiteBoolean;
    content: {
      base: string;
      inner: string;
    };
    body: {
      base: string;
      popup: string;
    };
    header: {
      base: string;
      popup: string;
      title: string;
      close: {
        base: string;
        icon: string;
      };
    };

closes #138

@rluders rluders requested a review from tulup-conner June 5, 2022 14:14
src/lib/components/Modal/ModalHeader.tsx Outdated Show resolved Hide resolved
src/lib/components/Modal/ModalHeader.tsx Outdated Show resolved Hide resolved
src/lib/components/Modal/index.tsx Outdated Show resolved Hide resolved
src/lib/components/Modal/index.tsx Outdated Show resolved Hide resolved
src/lib/components/Modal/index.tsx Outdated Show resolved Hide resolved
@rluders rluders requested a review from tulup-conner June 5, 2022 18:28
@rluders
Copy link
Collaborator Author

rluders commented Jun 5, 2022

@tulup-conner I had to change some other components interface as well, once I included the extra types, but nothing serious. I think that we will need to clean up some things in the future, but for now, it looks fine.

@rluders rluders merged commit 3ed4551 into themesberg:main Jun 5, 2022
@rluders rluders deleted the theme-modal-component branch June 5, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme: Modal component
2 participants