-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(component): Allow Card
to have href
#194
Conversation
Card
to have hrefCard
to have href
03c2dde
to
9962f52
Compare
I still need to change the form inputs to use Flowbite components. We can't change the Button in the Pricing card yet because Buttons' theme needs to be changed to fill the width of their container. |
ae65160
to
611235d
Compare
The [Default card on Flowbite docs](https://flowbite.com/docs/components/card/#default-card) is an anchor tag. Now you can add an `href` and it will use the `Default card` style seen here instead of the other examples, which use a `div`.
- [x] User profile card - [x] Card with form inputs - [x] E-commerce card - [x] Call to action card - [x] Card with list - [x] Pricing card - [x] Crypto card
- [x] with `href=".."`, should render an `<a>` - [x] should use `href` classes
611235d
to
1345360
Compare
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 98.92% 98.93%
=======================================
Files 127 127
Lines 7277 7309 +32
Branches 826 830 +4
=======================================
+ Hits 7199 7231 +32
Misses 78 78
Continue to review full report at Codecov.
|
Breaking changes
Card
s can now have anhref
:See the Flowbite docs on Cards, specifically, the
Default card
example.Bug fixes
Tests
Unit