Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): Allow Card to have href #194

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

tulup-conner
Copy link
Collaborator

@tulup-conner tulup-conner commented Jun 4, 2022

Breaking changes

Cards can now have an href:

<Card href="#">
  <h5 className="text-2xl font-bold tracking-tight text-gray-900 dark:text-white">
    Noteworthy technology acquisitions 2021
  </h5>
  <p className="font-normal text-gray-700 dark:text-gray-400">
    Here are the biggest enterprise technology acquisitions of 2021 so far, in reverse chronological order.
  </p>
</Card>

See the Flowbite docs on Cards, specifically, the Default card example.

Bug fixes

Tests

Unit

@tulup-conner tulup-conner changed the title fix(component): Allow Card to have href fix(component): Allow Card to have href Jun 4, 2022
@tulup-conner
Copy link
Collaborator Author

tulup-conner commented Jun 4, 2022

I still need to change the form inputs to use Flowbite components.

We can't change the Button in the Pricing card yet because Buttons' theme needs to be changed to fill the width of their container.

@tulup-conner tulup-conner deleted the fix/add-default-card branch June 5, 2022 23:11
@tulup-conner tulup-conner restored the fix/add-default-card branch June 6, 2022 08:28
@tulup-conner tulup-conner reopened this Jun 6, 2022
@tulup-conner tulup-conner force-pushed the fix/add-default-card branch 2 times, most recently from ae65160 to 611235d Compare June 6, 2022 08:33
@tulup-conner tulup-conner marked this pull request as ready for review June 6, 2022 08:39
@tulup-conner tulup-conner requested a review from rluders June 6, 2022 08:39
The [Default card on Flowbite docs](https://flowbite.com/docs/components/card/#default-card)
is an anchor tag. Now you can add an `href` and it
will use the `Default card` style seen here instead
of the other examples, which use a `div`.
- [x] User profile card
- [x] Card with form inputs
- [x] E-commerce card
- [x] Call to action card
- [x] Card with list
- [x] Pricing card
- [x] Crypto card
- [x] with `href=".."`, should render an `<a>`

- [x] should use `href` classes
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #194 (1345360) into main (9cd1eab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   98.92%   98.93%           
=======================================
  Files         127      127           
  Lines        7277     7309   +32     
  Branches      826      830    +4     
=======================================
+ Hits         7199     7231   +32     
  Misses         78       78           
Impacted Files Coverage Δ
src/lib/components/Card/Card.spec.tsx 100.00% <100.00%> (ø)
src/lib/components/Card/index.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd1eab...1345360. Read the comment docs.

@tulup-conner tulup-conner self-assigned this Jun 7, 2022
@rluders rluders merged commit 3be9786 into themesberg:main Jun 8, 2022
@tulup-conner tulup-conner deleted the fix/add-default-card branch June 8, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants