Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode flags for "start" command don't work #517

Closed
nirvdrum opened this issue Jul 19, 2016 · 2 comments · Fixed by #799
Closed

Mode flags for "start" command don't work #517

nirvdrum opened this issue Jul 19, 2016 · 2 comments · Fixed by #799
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these.
Milestone

Comments

@nirvdrum
Copy link

I may just be doing something wrong, but it looks like the --public and --private flags to the start command are completely ignored. The value from the config.js file always prevails. I started poking around at the source a bit and program.public and program.private are always undefined.

I'm running 2.0.0-pre.4.

@maxpoulin64 maxpoulin64 added the Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these. label Jul 19, 2016
@maxpoulin64
Copy link
Member

Hmm, I think the params are assigned the wrong way and that might be why they are undefined.

Just as a note, there was discussion about deprecating those options in favor of a more generic one that would allow to override any config options through the command-line. So those will likely go in the near future. I would always recommend to use the config.js anyway: it is created and loaded either way, so might as well use it.

@nirvdrum
Copy link
Author

Fair enough. I was just working through the docs in order and was confused when it didn't work the way I expected. Only then did I start looking at the config file in detail.

@xPaw xPaw closed this as completed in #799 Dec 19, 2016
@astorije astorije added this to the 2.2.0 milestone Dec 20, 2016
@astorije astorije added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants