Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show connection attempt status messages in network buffer #115

Closed
easymac opened this issue Feb 28, 2016 · 2 comments
Closed

Show connection attempt status messages in network buffer #115

easymac opened this issue Feb 28, 2016 · 2 comments
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Milestone

Comments

@easymac
Copy link
Contributor

easymac commented Feb 28, 2016

While a network connection is brokered, no messages appear in the network buffer until the connection is successful. We should see a Connecting to [host or name] message when a connection is started instead of a blank screen.

Error messages should also be piped there. Currently, connections that time out leave the network buffer entirely blank while emitting the following message on the server

Client#connect():
Error: connect ETIMEDOUT

In the event that auto-reconnect or auto-retry connections come to exist, I would also like to see Connection [lost or failed], retrying . . . messages.

@maxpoulin64 maxpoulin64 added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Feb 28, 2016
@xPaw
Copy link
Member

xPaw commented Mar 4, 2016

One of the things required for this to work correctly, is to move this code all the way up in the function: https://github.com/thelounge/lounge/blob/master/src/client.js#L213-L216

Then we will be able to send messages to network tab with what's happening.

@astorije
Copy link
Member

This issue seems to be fixed by #167.

@astorije astorije added this to the 2.0.0 milestone Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

No branches or pull requests

4 participants