Update eslint to the latest version 🚀 #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
greenkeeper
bot
added
the
Type: Dependencies
astorije
approved these changes
Mar 4, 2017
There was a problem hiding this comment.
2 new rules in this release, both not enabled in recommended setup, do we want/need to add them to our config?
no-compare-neg-zero: niche but why notnonblock-statement-body-position: Don't we disallow statement bodies without curly brackets? If so, we should be good without this rule.
xPaw
approved these changes
Mar 6, 2017
|
@xPaw, should we add |
Version 3.17.1 just got published.Update to this version instead 🚀 Release Notesv3.17.1
CommitsThe new version differs by 7 commits .
See the full diff. |
|
@astorije yeah whatever. |
xPaw
force-pushed
the
greenkeeper/eslint-3.17.0
branch
from
3f14460 to
9f053df
Compare
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…17.0 Update eslint to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.17.0 of eslint just got published.
The version 3.17.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
v3.17.0applyDefaultPatternsinline-comment-position(#8183) (alberto)+ +ato++ain space-unary-ops (#8176) (Alan Pierce)coverallsto ^2.11.16 (#8161) (alberto)createinno-use-before-define(#8166) (Justin Anastos)linefixandgh-got(#8160) (alberto)lines-around-commentdoesn't disallow empty lines (#8151) (alberto)ignoreRestSiblingsoption didn't cover arguments (fixes #8119) (#8120) (Toru Nagashima)Commits
The new version differs by 29 commits .
f882a113.17.06748c18Build: package.json and changelog update for 3.17.04fdf6d7Update: deprecateapplyDefaultPatternsinline-comment-position(#8183)25e5817Fix: Don't autofix+ +ato++ain space-unary-ops (#8176)a6ce8f9Build: Sort rules before dumping them to doc files (#8154)0af9057Chore: Upgrade to a patched version of mock-fs (fixes #8177) (#8188)bf4d8cfUpdate: ignore eslint comments in lines-arount-comment (fixes #4345) (#8155)dad20adNew: add SourceCode#getLocFromIndex and #getIndexFromLoc (fixes #8073) (#8158)18a519fUpdate: let RuleTester cases assert that no autofix occurs (fixes #8157) (#8163)a30eb8dDocs: improve documentation for RuleTester cases (#8162)a78ec9fChore: upgradecoverallsto ^2.11.16 (#8161)d02bd11Fix: padded-blocks autofix problems with comments (#8149)9994889Docs: Add missing space tocreateinno-use-before-define(#8166)4d542baDocs: Remove unneeded statement about autofix (#8164)20daea5New: no-compare-neg-zero rule (#8091)There are 29 commits in total. See the full diff.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴