Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make html container take the entire screen estate #821

Merged
merged 1 commit into from
Dec 19, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Dec 19, 2016

Fixes #793.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Dec 19, 2016
@xPaw xPaw added this to the 2.2.0 milestone Dec 19, 2016
@AlMcKinlay
Copy link
Member

Same with this one, probably doesn't need a second review.

@AlMcKinlay AlMcKinlay merged commit 094de1f into master Dec 19, 2016
@AlMcKinlay AlMcKinlay deleted the xpaw/html-100vh branch December 19, 2016 19:10
AlMcKinlay added a commit that referenced this pull request Feb 6, 2017
#821 fixed #793, but it appears since then, Chrome has changed the behaviour back to what it was befor ethe fix, so 2.2.0 on Chrome 56+ is even more broken.
@AlMcKinlay AlMcKinlay mentioned this pull request Feb 6, 2017
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Make html container take the entire screen estate
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
thelounge#821 fixed thelounge#793, but it appears since then, Chrome has changed the behaviour back to what it was befor ethe fix, so 2.2.0 on Chrome 56+ is even more broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants