Correctly remove closed sockets from oident file, remove unused functions #753
Conversation
xPaw
added
the
Type: Bug
|
|
||
| function makeRule(connection) { | ||
| return "to " + connection.socket.remoteAddress | ||
| _.forEach(this.connections, (connection) => { |
|
Checked this, just reporting it doesn't fix a bug with ident being the same. Fixes undefineds in .oidentd.conf though. |
| @@ -6,6 +6,7 @@ env: | |||
| browser: true | |||
| mocha: true | |||
| node: true | |||
| es6: true | |||
|
|
|||
| parserOptions: | |||
| ecmaVersion: 6 | |||
There was a problem hiding this comment.
es6: true makes ecmaVersion: 6 unnecessary (see eslint/eslint#7067). Do you mind removing parserOptions?
| hookSocket: function(socket, user) { | ||
| var that = this; | ||
| var id = null; | ||
| addSocket: function OidentdFileAddSocket(socket, user) { |
There was a problem hiding this comment.
If you make OidentdFile a class, I believe you could write these something like:
class OidentdFile {
/* ... */
addSocket(socket, user) {
/* ... */
}
/* ... */
}I definitely don't like naming a method differently than its descriptor (addSocket vs. OidentdFileAddSocket) and I even dislike more naming non-class-like functions with an uppercase, so I think that would be a win-win :)
There was a problem hiding this comment.
We definitely should start using classes, yeah. But for this PR I'll just remove the name additions.
There was a problem hiding this comment.
I think it would have been fine to convert them as we change them, so this PR was as a good time as any, but I'm fine either way.
Correctly remove closed sockets from oident file, remove unused functions
No description provided.