Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hexip ilines and fix storing client ip in config #749

Merged
merged 3 commits into from
Dec 11, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Nov 19, 2016

cc @MaxLeiter. This is mostly for demo purposes.

  • Fixes saving ip and hostmask in user config
  • Force user config save when connecting to a network
  • Update old existing networks to have ip/hostmask on socket attachment

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Nov 19, 2016
@xPaw xPaw added this to the 2.2.0 milestone Nov 19, 2016
@maxpoulin64
Copy link
Member

Hmm, the user's IP actually is stored on disk, or at least it is when webirc is enabled. Maybe we could recycle that for the hex ident?

Maybe we could even make the config option support passing in a function so people can customize it to whatever non-standard their servers need?

@xPaw
Copy link
Member Author

xPaw commented Nov 19, 2016

@maxpoulin64 Yeah I saw the webirc code for that, it was a little suspect, but probably can just always store ip/hostmask in the config.

As for the function, do you know servers that support other methods? Might not be worth the investment.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Nov 19, 2016
@xPaw xPaw changed the title Add support for hexip ilines Add support for hexip ilines and fix storing client ip in config Nov 19, 2016
@xPaw
Copy link
Member Author

xPaw commented Nov 21, 2016

This PR should hide the username field on the client if the option is enabled.

@PolarizedIons
Copy link
Contributor

I believe this would address issue #374 ?

@astorije
Copy link
Member

astorije commented Dec 9, 2016

This is mostly for demo purposes.

Just curious, is this something we want to include with the codebase we release then?

If yes, how ready is this?

@xPaw
Copy link
Member Author

xPaw commented Dec 9, 2016 via email

Copy link
Member

@maxpoulin64 maxpoulin64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me!

Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests!! 👏 💯

@astorije astorije merged commit 303fab8 into master Dec 11, 2016
@astorije astorije deleted the xpaw/hexip branch December 11, 2016 00:50
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Add support for hexip ilines and fix storing client ip in config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants