-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hexip ilines and fix storing client ip in config #749
Conversation
Hmm, the user's IP actually is stored on disk, or at least it is when webirc is enabled. Maybe we could recycle that for the hex ident? Maybe we could even make the config option support passing in a function so people can customize it to whatever non-standard their servers need? |
@maxpoulin64 Yeah I saw the webirc code for that, it was a little suspect, but probably can just always store ip/hostmask in the config. As for the function, do you know servers that support other methods? Might not be worth the investment. |
This PR should hide the username field on the client if the option is enabled. |
I believe this would address issue #374 ? |
Just curious, is this something we want to include with the codebase we release then? If yes, how ready is this? |
Should be ready.
…On Fri, 9 Dec 2016, 08:16 Jérémie Astori, ***@***.***> wrote:
This is mostly for demo purposes.
Just curious, is this something we want to include with the codebase we
release then?
If yes, how ready is this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#749 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAlb0wD5ih6E7_rcG-CU_CgjDnIsXtZyks5rGPJNgaJpZM4K3VCZ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests!! 👏 💯
Add support for hexip ilines and fix storing client ip in config
cc @MaxLeiter. This is mostly for demo purposes.