Add image to readme #694
Add image to readme #694
Conversation
| @@ -6,6 +6,9 @@ | |||
| [](https://david-dm.org/thelounge/lounge?type=dev) | |||
|
|
|||
| # The Lounge | |||
| <p align="center"> | |||
| <img src="https://sr.ht/s8rn.png" width="728" /> | |||
There was a problem hiding this comment.
We can use a screenshot from our website instead of using third party, https://github.com/thelounge/thelounge.github.io/tree/master/img/screenshots
|
I think it's way too big on our README. Since it's clickable, can you make it 400px at most please? |
|
@astorije 400px height and current width? |
|
Ah, sorry I didn't pay attention. 400px width, don't specify height so HTML applies the height while keeping source ratio. |
| @@ -6,6 +6,9 @@ | |||
| [](https://david-dm.org/thelounge/lounge?type=dev) | |||
|
|
|||
| # The Lounge | |||
| <p align="center"> | |||
| <img src="https://raw.githubusercontent.com/thelounge/thelounge.github.io/master/img/screenshots/example_css.png" width="550" /> | |||
There was a problem hiding this comment.
Why not directly https://thelounge.github.io/img/screenshots/example_css.png?
Also, <nitpick>there is no trailing slash on img elements in HTML5 :D</nitpick>.
Finally, add a new line between # The Lounge and the p element, some Markdown parsers (like npm's one at one point, not sure if still true) don't like that too much.
There was a problem hiding this comment.
Also, there is no trailing slash on img elements in HTML5 :D.
The spec doesn't say anything about the usage of self-closing tags for void elements though afaik. <img /> and <img> are both valid and are equal.
There was a problem hiding this comment.
It's valid, yes, but validity of the self-closing version has only been kept because of how widespread it is right now. Also, old habits die hard :)
I'd still argue <img> is the more correct way to write it of both, but that's definitely a nitpick. (Surprisingly, while Chrome converts them all to <br> in its dev console, Firefox uses <br></br> which is probably the least human-readable form for it lol...)
astorije
added
Type: Feature
|
Ping? |
|
Hmm, shouldn't we use a not so outdated screenshot? It's even got the old Shout square buttons, the old nick colors and no room topic! I also think it could be a good idea to avoid showing nicks and IRC networks to avoid unexpectedly bring traffic to those servers/channels from people coming in and saying "Came here from Lounge!" and disrupting the usual conversations there. A quick idea to make it not be so empty and not so big could be to have a screenshot in kind of a banner format, a bit like this, maybe even less tall:
|
|
Do you think I should use that specific screenshot, @maxpoulin64? |
|
@MaxLeiter: I guess we can. Maybe cut the window borders and add a bit of a shadow/gradient but I'm fine with it as-is |
|
Let's go for it as is. We'll change it later if needs be. |
|
Can you remove |
Image width is 793px, don't you find it too wide without the |
|
don't merge this - I have an idea for a better image (gif fading between themes) |
|
I don't think gif is a good idea.
…On Fri, 2 Dec 2016, 18:48 Max Leiter, ***@***.***> wrote:
don't merge this - I have an idea for a better image (gif fading between
themes)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#694 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAlb09-t0wVnNT4j7NZr0uxhGDNdXs-xks5rEEv1gaJpZM4KXnqf>
.
|
|
Something like this @xPaw ? (Rough draft, will be slower and smaller) |
|
IMO static image is better.
…On Fri, 2 Dec 2016, 18:54 Max Leiter, ***@***.***> wrote:
Something like this @xPaw <https://github.com/xPaw> ? (Rough draft)
http://im2.ezgif.com/tmp/ezgif.com-7e6f723012.gif
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#694 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAlb01quEOQD7s-9pKHkorAunsr-a_5bks5rEE1YgaJpZM4KXnqf>
.
|
|
Is there a nice way to show multiple themes? We ship with default but I know a lot of people like Morning. |
|
In that case images side by side might be better.
…On Fri, 2 Dec 2016, 18:56 Max Leiter, ***@***.***> wrote:
Is there a nice way to show multiple themes? We ship with default but I
know a lot of people like Morning.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#694 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAlb0zgQHaAnCqXIQT51qfcRc4k5Cx8Mks5rEE2ygaJpZM4KXnqf>
.
|
|
I like the gif |
|
Alright, @MaxLeiter is OK with this, we can make it all fancy later :) |
Add image to readme
Live example: https://github.com/MaxLeiter/lounge/blob/MaxLeiter-image/README.md