Prevent Ctrl-Tab from triggering tab completion

[hho]

Fixes #529

This is probably the simplest workaround for Firefox sending a keydown event when switching browser tabs via Ctrl-Tab

[maxpoulin64]

Yeah, this is a pretty cheap fix, but we don't have a key bind on that so that's 👍 for now until we can get a better library I guess.

I see that preventDefault was used, I wonder why that doesn't work with the new textarea...

[astorije]

Before +1ing this, I would like to understand why this was working just fine on an input element but not a textarea. It may be browser weirdness because it's fine on Chrome (what about IE/Edge and Safari?), but it may also be our code that doesn't work well with textareas...

@hho, did you investigate a little bit there by any chance?

[hho]

@astorije 2.0.0-pre.4 doesn't even have a <textarea> yet, does it? It seems to be only a Firefox bug, and an old one at that. I actually don't know how this ever worked in FF… ¯\_(ツ)_/¯

[astorije]

Indeed, and that's why I was willing to investigate why it works fine with an input but not with a textarea.
But if you found that it's a bug specifically on textareas...

[hho]

I'm sorry, but I don't understand:
2.0.0-pre.4 uses <input> and it doesn't work correctly with Firefox (this PR fixes that).
To me, this doesn't seem to have anything to do with textareas at all?

[astorije]

Woosh, my bad! When I tested, I could trigger this bug on <textarea> elements but not <input> elements, which is why I had marked this as a regression, but I guess it's not.
Thanks for sticking with my slowness 😅

[astorije]

👍 and merging, but let's open this to https://github.com/erming/tabcomplete to avoid monkey-patching libraries Done.