Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidentally removed border-radius #537

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

astorije
Copy link
Member

This was removed by this. I don't think this as further consequences but I would prefer @maxpoulin64 to confirm that.

Screenshots

This is very minor, but there is idiom about the devil and details :-)

Before fix After fix
screen shot 2016-07-31 at 17 50 14 screen shot 2016-07-31 at 17 49 40
screen shot 2016-07-31 at 17 50 43 screen shot 2016-07-31 at 17 49 56

@astorije astorije added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels Jul 31, 2016
@astorije astorije added this to the 2.0.0 milestone Jul 31, 2016
@maxpoulin64 maxpoulin64 merged commit bdfa740 into master Aug 1, 2016
@maxpoulin64 maxpoulin64 deleted the astorije/fix-border-radius branch August 1, 2016 16:09
@maxpoulin64
Copy link
Member

Thinking back of it, I probably removed it accidentally while testing some other things. I moved things around a lot before settling with that solution, so I probably forgot to undo that one. Normally I clean up my commits to remove all unwanted changes, but I guess that one went through.

astorije added a commit that referenced this pull request Aug 19, 2016
…and for all

#537 only fixed it on chat windows,
but for some browser-specific display bug/reason not on settings, login, ...
astorije added a commit that referenced this pull request Aug 19, 2016
…and for all

#537 only fixed it on chat windows,
but for some browser-specific display bug/reason not on settings, login, ...
astorije added a commit that referenced this pull request Aug 19, 2016
…and for all

#537 only fixed it on chat windows,
but for some browser-specific display bug/reason not on settings, login, ...
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…adius

Fix accidentally removed border-radius
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…and for all

thelounge#537 only fixed it on chat windows,
but for some browser-specific display bug/reason not on settings, login, ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants