src/client: fix storing updated token, ensure client config is always an object #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamboman
force-pushed
the
fix/save-token
branch
2 times, most recently
from
e938189 to
fbd9db4
Compare
williamboman
changed the title
|
@xPaw, do you mind taking a quick look at this one? |
astorije
added
the
Type: Bug
| if (config) { | ||
| if (!config.token) { | ||
| client.updateToken(function() { | ||
| client.manager.updateUser(client.name, {token: config.token}); |
There was a problem hiding this comment.
The problem was specifically this line, which should have been client.config.token.
|
👍 Good catch. Feel free to fix my comments, if you want to. |
williamboman
force-pushed
the
fix/save-token
branch
2 times, most recently
from
fd3cb25 to
cdb3618
Compare
williamboman
changed the title
williamboman
force-pushed
the
fix/save-token
branch
3 times, most recently
from
d5c9f1b to
a658dc2
Compare
| @@ -55,6 +55,9 @@ var inputs = [ | |||
| }, {}); | |||
|
|
|||
| function Client(manager, name, config) { | |||
| if (config === undefined || typeof config !== "object") { | |||
There was a problem hiding this comment.
undefined isn't an object, so the first check isn't necessary.
williamboman
force-pushed
the
fix/save-token
branch
from
a658dc2 to
6551dd9
Compare
| delay += 1000; | ||
| }); | ||
|
|
||
| log.info("User '" + name + "' loaded"); |
There was a problem hiding this comment.
Add a check for name, otherwise it's going to print undefined for users in public mode.
williamboman
force-pushed
the
fix/save-token
branch
2 times, most recently
from
bdec503 to
4971d18
Compare
williamboman
changed the title
williamboman
force-pushed
the
fix/save-token
branch
from
4971d18 to
fe96857
Compare
|
Ok patch should be final now. |
williamboman
force-pushed
the
fix/save-token
branch
from
fe96857 to
5126261
Compare
|
Still 👍 |
williamboman
force-pushed
the
fix/save-token
branch
from
5126261 to
03398d5
Compare
This also fixes an issue where the token would not be stored in the user file.
williamboman
force-pushed
the
fix/save-token
branch
from
03398d5 to
32b46bb
Compare
|
👍 and merging, thanks! |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
src/client: fix storing updated token, ensure client config is always an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes an issue where the token would not be stored in the
user file.
Just want to point out that
config !== client.configas well (hence breakage in the first place).