-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not display the sidebar on sign-in page #420
Conversation
Instead of moving the whole layout, can't you just hide sidebar and footer when |
Good call, I'll try that. |
1317700
to
198f2f3
Compare
Also: - Remove burger menu icon on mobile version of sign-in page - Add the .signed-out class to the initial body instead of only when sign-in has failed - Remove hiding connect and logout button icons, which was buggy and is now useless anyway
198f2f3
to
1f4e2b4
Compare
Much better indeed, @xPaw, thanks for the suggestion! |
Indeed much better, will test and merge. |
Looks fine, however I'd like to display |
@xPaw, I agree with the intent, but I'd rather see this in its own PR, especially since this was not available before this PR (actually, you could see this by going to the settings and reading the About statement, but that's a side effect, really). If you want, I can change from "Sign in" to "Sign in to The Lounge" until this is taken up ( |
This change was originally made in thelounge#420 then I broke it for themes in thelounge#615, sigh...
Do not display the sidebar on sign-in page
This change was originally made in thelounge#420 then I broke it for themes in thelounge#615, sigh...
The sidebar is really useless on the authentication page. The settings page has no effect until logged, while icons to add a network and log out are purely wrong.
This is an attempt to make the sign-in page use the whole viewport:
The commit also:
.signed-out
class to the initial body instead of only when sign-in has failedResult
#### Current issues - [x] ~~The sign-in icon is not even displayed anymore, and has no value, so I removed _most_ of it. Because of how the client displays the sign-in form, I cannot simply remove it: when receiving the `auth` event, a click is emitted on the button that activates the right window, changes the page title, ... Not pretty. Any suggestion on improving this? I'm thinking of moving that logic to a different function that the click handler calls, and the `auth` event handler could call it without resorting to a click. Does that sound any better?~~ Scratch that, I'll tackle this in a further PR. - [x] ~~Right now, there is no scrollbar on the sign-in page, which is a problem. I'll look into that issue, but if someone sees something obvious, please speak up :-)~~ Fixed along with implementing @xPaw's suggestion. - [x] ~~The loading page looks gross with this. I should apply behavior of this PR to the loading page as well (no sidebar), and make sure the input field does not apply there either.~~ Thanks to @xPaw's suggestion, this PR also applies to the loading page \o/