Fix description of host and bind config options
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpoulin64
added
Type: Feature
|
@maxpoulin64, FYI, this commit comes from #1, that is, even before I had time to change all names from Shout to The Lounge :D. |
| @@ -11,7 +11,7 @@ module.exports = { | |||
| public: true, | |||
|
|
|||
| // | |||
| // Allow connections from this host. | |||
| // IP address or hostname for the web server to listen on. | |||
There was a problem hiding this comment.
Perhaps specify that listening on 0.0.0.0 will listen on all available interfaces?
|
cool that was confusing |
Commit da54263 introduced a totally wrong description for those options. This one describes better what exactly those options do.
maxpoulin64
force-pushed
the
fix-config-doc
branch
from
ad67f5a to
18f0f44
Compare
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Commit da54263 introduced a totally wrong description for those options. This one describes better what exactly those options do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit da54263 introduced a totally wrong description for those options. This one describes better what exactly those options do.
@astorije: Do you have any idea how that commit made its way in? It doesn't seem to be tied to any PR, nor seem to have gone through any kind of review process. And apparently, it's not in Shout's repo.